mirror of
https://github.com/langbot-app/LangBot.git
synced 2025-11-25 03:15:06 +08:00
* feat: add comprehensive unit tests for pipeline stages * fix: deps install in ci * ci: use venv * ci: run run_tests.sh * fix: resolve circular import issues in pipeline tests Update all test files to use lazy imports via importlib.import_module() to avoid circular dependency errors. Fix mock_conversation fixture to properly mock list.copy() method. Changes: - Use lazy import pattern in all test files - Fix conftest.py fixture for conversation messages - Add integration test file for full import tests - Update documentation with known issues and workarounds Tests now successfully avoid circular import errors while maintaining full test coverage of pipeline stages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: add comprehensive testing summary Document implementation details, challenges, solutions, and future improvements for the pipeline unit test suite. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: rewrite unit tests to test actual pipeline stage code Rewrote unit tests to properly test real stage implementations instead of mock logic: - Test actual BanSessionCheckStage with 7 test cases (100% coverage) - Test actual RateLimit stage with 3 test cases (70% coverage) - Test actual PipelineManager with 5 test cases - Use lazy imports via import_module to avoid circular dependencies - Import pipelinemgr first to ensure proper stage registration - Use Query.model_construct() to bypass Pydantic validation in tests - Remove obsolete pure unit tests that didn't test real code - All 20 tests passing with 48% overall pipeline coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test: add unit tests for GroupRespondRuleCheckStage Added comprehensive unit tests for resprule stage: - Test person message skips rule check - Test group message with no matching rules (INTERRUPT) - Test group message with matching rule (CONTINUE) - Test AtBotRule removes At component correctly - Test AtBotRule when no At component present Coverage: 100% on resprule.py and atbot.py All 25 tests passing with 51% overall pipeline coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: restructure tests to tests/unit_tests/pipeline Reorganized test directory structure to support multiple test categories: - Move tests/pipeline → tests/unit_tests/pipeline - Rename .github/workflows/pipeline-tests.yml → run-tests.yml - Update run_tests.sh to run all unit tests (not just pipeline) - Update workflow to trigger on all pkg/** and tests/** changes - Coverage now tracks entire pkg/ module instead of just pipeline This structure allows for easy addition of more unit tests for other modules in the future. All 25 tests passing with 21% overall pkg coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * ci: upload codecov report * ci: codecov file * ci: coverage.xml --------- Co-authored-by: Claude <noreply@anthropic.com>
167 lines
5.2 KiB
Python
167 lines
5.2 KiB
Python
"""
|
|
PipelineManager unit tests
|
|
"""
|
|
|
|
import pytest
|
|
from unittest.mock import AsyncMock, Mock
|
|
from importlib import import_module
|
|
import sqlalchemy
|
|
|
|
|
|
def get_pipelinemgr_module():
|
|
return import_module('pkg.pipeline.pipelinemgr')
|
|
|
|
|
|
def get_stage_module():
|
|
return import_module('pkg.pipeline.stage')
|
|
|
|
|
|
def get_entities_module():
|
|
return import_module('pkg.pipeline.entities')
|
|
|
|
|
|
def get_persistence_pipeline_module():
|
|
return import_module('pkg.entity.persistence.pipeline')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_pipeline_manager_initialize(mock_app):
|
|
"""Test pipeline manager initialization"""
|
|
pipelinemgr = get_pipelinemgr_module()
|
|
|
|
mock_app.persistence_mgr.execute_async = AsyncMock(return_value=Mock(all=Mock(return_value=[])))
|
|
|
|
manager = pipelinemgr.PipelineManager(mock_app)
|
|
await manager.initialize()
|
|
|
|
assert manager.stage_dict is not None
|
|
assert len(manager.pipelines) == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_load_pipeline(mock_app):
|
|
"""Test loading a single pipeline"""
|
|
pipelinemgr = get_pipelinemgr_module()
|
|
persistence_pipeline = get_persistence_pipeline_module()
|
|
|
|
mock_app.persistence_mgr.execute_async = AsyncMock(return_value=Mock(all=Mock(return_value=[])))
|
|
|
|
manager = pipelinemgr.PipelineManager(mock_app)
|
|
await manager.initialize()
|
|
|
|
# Create test pipeline entity
|
|
pipeline_entity = Mock(spec=persistence_pipeline.LegacyPipeline)
|
|
pipeline_entity.uuid = 'test-uuid'
|
|
pipeline_entity.stages = []
|
|
pipeline_entity.config = {'test': 'config'}
|
|
|
|
await manager.load_pipeline(pipeline_entity)
|
|
|
|
assert len(manager.pipelines) == 1
|
|
assert manager.pipelines[0].pipeline_entity.uuid == 'test-uuid'
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_pipeline_by_uuid(mock_app):
|
|
"""Test getting pipeline by UUID"""
|
|
pipelinemgr = get_pipelinemgr_module()
|
|
persistence_pipeline = get_persistence_pipeline_module()
|
|
|
|
mock_app.persistence_mgr.execute_async = AsyncMock(return_value=Mock(all=Mock(return_value=[])))
|
|
|
|
manager = pipelinemgr.PipelineManager(mock_app)
|
|
await manager.initialize()
|
|
|
|
# Create and add test pipeline
|
|
pipeline_entity = Mock(spec=persistence_pipeline.LegacyPipeline)
|
|
pipeline_entity.uuid = 'test-uuid'
|
|
pipeline_entity.stages = []
|
|
pipeline_entity.config = {}
|
|
|
|
await manager.load_pipeline(pipeline_entity)
|
|
|
|
# Test retrieval
|
|
result = await manager.get_pipeline_by_uuid('test-uuid')
|
|
assert result is not None
|
|
assert result.pipeline_entity.uuid == 'test-uuid'
|
|
|
|
# Test non-existent UUID
|
|
result = await manager.get_pipeline_by_uuid('non-existent')
|
|
assert result is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_remove_pipeline(mock_app):
|
|
"""Test removing a pipeline"""
|
|
pipelinemgr = get_pipelinemgr_module()
|
|
persistence_pipeline = get_persistence_pipeline_module()
|
|
|
|
mock_app.persistence_mgr.execute_async = AsyncMock(return_value=Mock(all=Mock(return_value=[])))
|
|
|
|
manager = pipelinemgr.PipelineManager(mock_app)
|
|
await manager.initialize()
|
|
|
|
# Create and add test pipeline
|
|
pipeline_entity = Mock(spec=persistence_pipeline.LegacyPipeline)
|
|
pipeline_entity.uuid = 'test-uuid'
|
|
pipeline_entity.stages = []
|
|
pipeline_entity.config = {}
|
|
|
|
await manager.load_pipeline(pipeline_entity)
|
|
assert len(manager.pipelines) == 1
|
|
|
|
# Remove pipeline
|
|
await manager.remove_pipeline('test-uuid')
|
|
assert len(manager.pipelines) == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_runtime_pipeline_execute(mock_app, sample_query):
|
|
"""Test runtime pipeline execution"""
|
|
pipelinemgr = get_pipelinemgr_module()
|
|
stage = get_stage_module()
|
|
persistence_pipeline = get_persistence_pipeline_module()
|
|
|
|
# Create mock stage that returns a simple result dict (avoiding Pydantic validation)
|
|
mock_result = Mock()
|
|
mock_result.result_type = Mock()
|
|
mock_result.result_type.value = 'CONTINUE' # Simulate enum value
|
|
mock_result.new_query = sample_query
|
|
mock_result.user_notice = ''
|
|
mock_result.console_notice = ''
|
|
mock_result.debug_notice = ''
|
|
mock_result.error_notice = ''
|
|
|
|
# Make it look like ResultType.CONTINUE
|
|
from unittest.mock import MagicMock
|
|
CONTINUE = MagicMock()
|
|
CONTINUE.__eq__ = lambda self, other: True # Always equal for comparison
|
|
mock_result.result_type = CONTINUE
|
|
|
|
mock_stage = Mock(spec=stage.PipelineStage)
|
|
mock_stage.process = AsyncMock(return_value=mock_result)
|
|
|
|
# Create stage container
|
|
stage_container = pipelinemgr.StageInstContainer(inst_name='TestStage', inst=mock_stage)
|
|
|
|
# Create pipeline entity
|
|
pipeline_entity = Mock(spec=persistence_pipeline.LegacyPipeline)
|
|
pipeline_entity.config = sample_query.pipeline_config
|
|
|
|
# Create runtime pipeline
|
|
runtime_pipeline = pipelinemgr.RuntimePipeline(mock_app, pipeline_entity, [stage_container])
|
|
|
|
# Mock plugin connector
|
|
event_ctx = Mock()
|
|
event_ctx.is_prevented_default = Mock(return_value=False)
|
|
mock_app.plugin_connector.emit_event = AsyncMock(return_value=event_ctx)
|
|
|
|
# Add query to cached_queries to prevent KeyError in finally block
|
|
mock_app.query_pool.cached_queries[sample_query.query_id] = sample_query
|
|
|
|
# Execute pipeline
|
|
await runtime_pipeline.run(sample_query)
|
|
|
|
# Verify stage was called
|
|
mock_stage.process.assert_called_once()
|