mirror of
https://github.com/AlistGo/alist.git
synced 2025-11-25 03:15:10 +08:00
* 标签管理 * pr检查优化 * feat(role): Implement role management functionality - Add role management routes in `server/router.go` for listing, getting, creating, updating, and deleting roles - Introduce `initRoles()` in `internal/bootstrap/data/data.go` for initializing roles during bootstrap - Create `internal/op/role.go` to handle role operations including caching and singleflight - Implement role handler functions in `server/handles/role.go` for API responses - Define database operations for roles in `internal/db/role.go` - Extend `internal/db/db.go` for role model auto-migration - Design `internal/model/role.go` to represent role structure with ID, name, description, base path, and permissions - Initialize default roles (`admin` and `guest`) in `internal/bootstrap/data/role.go` during startup * refactor(user roles): Support multiple roles for users - Change the `Role` field type from `int` to `[]int` in `drivers/alist_v3/types.go` and `drivers/quqi/types.go`. - Update the `Role` field in `internal/model/user.go` to use a new `Roles` type with JSON and database support. - Modify `IsGuest` and `IsAdmin` methods to check for roles using `Contains` method. - Update `GetUserByRole` method in `internal/db/user.go` to handle multiple roles. - Add `roles.go` to define a new `Roles` type with JSON marshalling and scanning capabilities. - Adjust code in `server/handles/user.go` to compare roles with `utils.SliceEqual`. - Change role initialization for users in `internal/bootstrap/data/dev.go` and `internal/bootstrap/data/user.go`. - Update `Role` handling in `server/handles/task.go`, `server/handles/ssologin.go`, and `server/handles/ldap_login.go`. * feat(user/role): Add path limit check for user and role permissions - Add new permission bit for checking path limits in `user.go` - Implement `CheckPathLimit` method in `User` struct to validate path access - Modify `JoinPath` method in `User` to enforce path limit checks - Update `role.go` to include path limit logic in `Role` struct - Document new permission bit in `Role` and `User` comments for clarity * feat(permission): Add role-based permission handling - Introduce `role_perm.go` for managing user permissions based on roles. - Implement `HasPermission` and `MergeRolePermissions` functions. - Update `webdav.go` to utilize role-based permissions instead of direct user checks. - Modify `fsup.go` to integrate `CanAccessWithRoles` function. - Refactor `fsread.go` to use `common.HasPermission` for permission validation. - Adjust `fsmanage.go` for role-based access control checks. - Enhance `ftp.go` and `sftp.go` to manage FTP access via roles. - Update `fsbatch.go` to employ `MergeRolePermissions` for batch operations. - Replace direct user permission checks with role-based permission handling across various modules. * refactor(user): Replace integer role values with role IDs - Change `GetAdmin()` and `GetGuest()` functions to retrieve role by name and use role ID. - Add patch for version `v3.45.2` to convert legacy integer roles to role IDs. - Update `dev.go` and `user.go` to use role IDs instead of integer values for roles. - Remove redundant code in `role.go` related to guest role creation. - Modify `ssologin.go` and `ldap_login.go` to set user roles to nil instead of using integer roles. - Introduce `convert_roles.go` to handle conversion of legacy roles and ensure role existence in the database. * feat(role_perm): implement support for multiple base paths for roles - Modify role permission checks to support multiple base paths - Update role creation and update functions to handle multiple base paths - Add migration script to convert old base_path to base_paths - Define new Paths type for handling multiple paths in the model - Adjust role model to replace BasePath with BasePaths - Update existing patches to handle roles with multiple base paths - Update bootstrap data to reflect the new base_paths field * feat(role): Restrict modifications to default roles (admin and guest) - Add validation to prevent changes to "admin" and "guest" roles in `UpdateRole` and `DeleteRole` functions. - Introduce `ErrChangeDefaultRole` error in `internal/errs/role.go` to standardize error messaging. - Update role-related API handlers in `server/handles/role.go` to enforce the new restriction. - Enhance comments in `internal/bootstrap/data/role.go` to clarify the significance of default roles. - Ensure consistent error responses for unauthorized role modifications across the application. * 🔄 **refactor(role): Enhance role permission handling** - Replaced `BasePaths` with `PermissionPaths` in `Role` struct for better permission granularity. - Introduced JSON serialization for `PermissionPaths` using `RawPermission` field in `Role` struct. - Implemented `BeforeSave` and `AfterFind` GORM hooks for handling `PermissionPaths` serialization. - Refactored permission calculation logic in `role_perm.go` to work with `PermissionPaths`. - Updated role creation logic to initialize `PermissionPaths` for `admin` and `guest` roles. - Removed deprecated `CheckPathLimit` method from `Role` struct. * fix(model/user/role): update permission settings for admin and role - Change `RawPermission` field in `role.go` to hide JSON representation - Update `Permission` field in `user.go` to `0xFFFF` for full access - Modify `PermissionScopes` in `role.go` to `0xFFFF` for enhanced permissions * 🔒 feat(role-permissions): Enhance role-based access control - Introduce `canReadPathByRole` function in `role_perm.go` to verify path access based on user roles - Modify `CanAccessWithRoles` to include role-based path read check - Add `RoleNames` and `Permissions` to `UserResp` struct in `auth.go` for enhanced user role and permission details - Implement role details aggregation in `auth.go` to populate `RoleNames` and `Permissions` - Update `User` struct in `user.go` to include `RolesDetail` for more detailed role information - Enhance middleware in `auth.go` to load and verify detailed role information for users - Move `guest` user initialization logic in `user.go` to improve code organization and avoid repetition * 🔒 fix(permissions): Add permission checks for archive operations - Add `MergeRolePermissions` and `HasPermission` checks to validate user access for reading archives - Ensure users have `PermReadArchives` before proceeding with `GetNearestMeta` in specific archive paths - Implement permission checks for decompress operations, requiring `PermDecompress` for source paths - Return `PermissionDenied` errors with 403 status if user lacks necessary permissions * 🔒 fix(server): Add permission check for offline download - Add permission merging logic for user roles - Check user has permission for offline download addition - Return error response with "permission denied" if check fails * ✨ feat(role-permission): Implement path-based role permission checks - Add `CheckPathLimitWithRoles` function to validate access based on `PermPathLimit` permission. - Integrate `CheckPathLimitWithRoles` in `offline_download` to enforce path-based access control. - Apply `CheckPathLimitWithRoles` across file system management operations (e.g., creation, movement, deletion). - Ensure `CheckPathLimitWithRoles` is invoked for batch operations and archive-related actions. - Update error handling to return `PermissionDenied` if the path validation fails. - Import `errs` package in `offline_download` for consistent error responses. * ✨ feat(role-permission): Implement path-based role permission checks - Add `CheckPathLimitWithRoles` function to validate access based on `PermPathLimit` permission. - Integrate `CheckPathLimitWithRoles` in `offline_download` to enforce path-based access control. - Apply `CheckPathLimitWithRoles` across file system management operations (e.g., creation, movement, deletion). - Ensure `CheckPathLimitWithRoles` is invoked for batch operations and archive-related actions. - Update error handling to return `PermissionDenied` if the path validation fails. - Import `errs` package in `offline_download` for consistent error responses. * ♻️ refactor(access-control): Update access control logic to use role-based checks - Remove deprecated logic from `CanAccess` function in `check.go`, replacing it with `CanAccessWithRoles` for improved role-based access control. - Modify calls in `search.go` to use `CanAccessWithRoles` for more precise handling of permissions. - Update `fsread.go` to utilize `CanAccessWithRoles`, ensuring accurate access validation based on user roles. - Simplify import statements in `check.go` by removing unused packages to clean up the codebase. * ✨ feat(fs): Improve visibility logic for hidden files - Import `server/common` package to handle permissions more robustly - Update `whetherHide` function to use `MergeRolePermissions` for user-specific path permissions - Replace direct user checks with `HasPermission` for `PermSeeHides` - Enhance logic to ensure `nil` user cases are handled explicitly * 标签管理 * feat(db/auth/user): Enhance role handling and clean permission paths - Comment out role modification checks in `server/handles/user.go` to allow flexible role changes. - Improve permission path handling in `server/handles/auth.go` by normalizing and deduplicating paths. - Introduce `addedPaths` map in `CurrentUser` to prevent duplicate permissions. * feat(storage/db): Implement role permissions path prefix update - Add `UpdateRolePermissionsPathPrefix` function in `role.go` to update role permissions paths. - Modify `storage.go` to call the new function when the mount path is renamed. - Introduce path cleaning and prefix matching logic for accurate path updates. - Ensure roles are updated only if their permission scopes are modified. - Handle potential errors with informative messages during database operations. * feat(role-migration): Implement role conversion and introduce NEWGENERAL role - Add `NEWGENERAL` to the roles enumeration in `user.go` - Create new file `convert_role.go` for migrating legacy roles to new model - Implement `ConvertLegacyRoles` function to handle role conversion with permission scopes - Add `convert_role.go` patch to `all.go` under version `v3.46.0` * feat(role/auth): Add role retrieval by user ID and update path prefixes - Add `GetRolesByUserID` function for efficient role retrieval by user ID - Implement `UpdateUserBasePathPrefix` to update user base paths - Modify `UpdateRolePermissionsPathPrefix` to return modified role IDs - Update `auth.go` middleware to use the new role retrieval function - Refresh role and user caches upon path prefix updates to maintain consistency --------- Co-authored-by: Leslie-Xy <540049476@qq.com>
226 lines
6.9 KiB
Go
226 lines
6.9 KiB
Go
package handles
|
|
|
|
import (
|
|
"github.com/alist-org/alist/v3/internal/model"
|
|
"github.com/alist-org/alist/v3/internal/task"
|
|
"math"
|
|
"time"
|
|
|
|
"github.com/alist-org/alist/v3/internal/fs"
|
|
"github.com/alist-org/alist/v3/internal/offline_download/tool"
|
|
"github.com/alist-org/alist/v3/pkg/utils"
|
|
"github.com/alist-org/alist/v3/server/common"
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/xhofe/tache"
|
|
)
|
|
|
|
type TaskInfo struct {
|
|
ID string `json:"id"`
|
|
Name string `json:"name"`
|
|
Creator string `json:"creator"`
|
|
CreatorRole model.Roles `json:"creator_role"`
|
|
State tache.State `json:"state"`
|
|
Status string `json:"status"`
|
|
Progress float64 `json:"progress"`
|
|
StartTime *time.Time `json:"start_time"`
|
|
EndTime *time.Time `json:"end_time"`
|
|
TotalBytes int64 `json:"total_bytes"`
|
|
Error string `json:"error"`
|
|
}
|
|
|
|
func getTaskInfo[T task.TaskExtensionInfo](task T) TaskInfo {
|
|
errMsg := ""
|
|
if task.GetErr() != nil {
|
|
errMsg = task.GetErr().Error()
|
|
}
|
|
progress := task.GetProgress()
|
|
// if progress is NaN, set it to 100
|
|
if math.IsNaN(progress) {
|
|
progress = 100
|
|
}
|
|
creatorName := ""
|
|
var creatorRole model.Roles
|
|
if task.GetCreator() != nil {
|
|
creatorName = task.GetCreator().Username
|
|
creatorRole = task.GetCreator().Role
|
|
}
|
|
return TaskInfo{
|
|
ID: task.GetID(),
|
|
Name: task.GetName(),
|
|
Creator: creatorName,
|
|
CreatorRole: creatorRole,
|
|
State: task.GetState(),
|
|
Status: task.GetStatus(),
|
|
Progress: progress,
|
|
StartTime: task.GetStartTime(),
|
|
EndTime: task.GetEndTime(),
|
|
TotalBytes: task.GetTotalBytes(),
|
|
Error: errMsg,
|
|
}
|
|
}
|
|
|
|
func getTaskInfos[T task.TaskExtensionInfo](tasks []T) []TaskInfo {
|
|
return utils.MustSliceConvert(tasks, getTaskInfo[T])
|
|
}
|
|
|
|
func argsContains[T comparable](v T, slice ...T) bool {
|
|
return utils.SliceContains(slice, v)
|
|
}
|
|
|
|
func getUserInfo(c *gin.Context) (bool, uint, bool) {
|
|
if user, ok := c.Value("user").(*model.User); ok {
|
|
return user.IsAdmin(), user.ID, true
|
|
} else {
|
|
return false, 0, false
|
|
}
|
|
}
|
|
|
|
func getTargetedHandler[T task.TaskExtensionInfo](manager task.Manager[T], callback func(c *gin.Context, task T)) gin.HandlerFunc {
|
|
return func(c *gin.Context) {
|
|
isAdmin, uid, ok := getUserInfo(c)
|
|
if !ok {
|
|
// if there is no bug, here is unreachable
|
|
common.ErrorStrResp(c, "user invalid", 401)
|
|
return
|
|
}
|
|
t, ok := manager.GetByID(c.Query("tid"))
|
|
if !ok {
|
|
common.ErrorStrResp(c, "task not found", 404)
|
|
return
|
|
}
|
|
if !isAdmin && uid != t.GetCreator().ID {
|
|
// to avoid an attacker using error messages to guess valid TID, return a 404 rather than a 403
|
|
common.ErrorStrResp(c, "task not found", 404)
|
|
return
|
|
}
|
|
callback(c, t)
|
|
}
|
|
}
|
|
|
|
func getBatchHandler[T task.TaskExtensionInfo](manager task.Manager[T], callback func(task T)) gin.HandlerFunc {
|
|
return func(c *gin.Context) {
|
|
isAdmin, uid, ok := getUserInfo(c)
|
|
if !ok {
|
|
common.ErrorStrResp(c, "user invalid", 401)
|
|
return
|
|
}
|
|
var tids []string
|
|
if err := c.ShouldBind(&tids); err != nil {
|
|
common.ErrorStrResp(c, "invalid request format", 400)
|
|
return
|
|
}
|
|
retErrs := make(map[string]string)
|
|
for _, tid := range tids {
|
|
t, ok := manager.GetByID(tid)
|
|
if !ok || (!isAdmin && uid != t.GetCreator().ID) {
|
|
retErrs[tid] = "task not found"
|
|
continue
|
|
}
|
|
callback(t)
|
|
}
|
|
common.SuccessResp(c, retErrs)
|
|
}
|
|
}
|
|
|
|
func taskRoute[T task.TaskExtensionInfo](g *gin.RouterGroup, manager task.Manager[T]) {
|
|
g.GET("/undone", func(c *gin.Context) {
|
|
isAdmin, uid, ok := getUserInfo(c)
|
|
if !ok {
|
|
// if there is no bug, here is unreachable
|
|
common.ErrorStrResp(c, "user invalid", 401)
|
|
return
|
|
}
|
|
common.SuccessResp(c, getTaskInfos(manager.GetByCondition(func(task T) bool {
|
|
// avoid directly passing the user object into the function to reduce closure size
|
|
return (isAdmin || uid == task.GetCreator().ID) &&
|
|
argsContains(task.GetState(), tache.StatePending, tache.StateRunning, tache.StateCanceling,
|
|
tache.StateErrored, tache.StateFailing, tache.StateWaitingRetry, tache.StateBeforeRetry)
|
|
})))
|
|
})
|
|
g.GET("/done", func(c *gin.Context) {
|
|
isAdmin, uid, ok := getUserInfo(c)
|
|
if !ok {
|
|
// if there is no bug, here is unreachable
|
|
common.ErrorStrResp(c, "user invalid", 401)
|
|
return
|
|
}
|
|
common.SuccessResp(c, getTaskInfos(manager.GetByCondition(func(task T) bool {
|
|
return (isAdmin || uid == task.GetCreator().ID) &&
|
|
argsContains(task.GetState(), tache.StateCanceled, tache.StateFailed, tache.StateSucceeded)
|
|
})))
|
|
})
|
|
g.POST("/info", getTargetedHandler(manager, func(c *gin.Context, task T) {
|
|
common.SuccessResp(c, getTaskInfo(task))
|
|
}))
|
|
g.POST("/cancel", getTargetedHandler(manager, func(c *gin.Context, task T) {
|
|
manager.Cancel(task.GetID())
|
|
common.SuccessResp(c)
|
|
}))
|
|
g.POST("/delete", getTargetedHandler(manager, func(c *gin.Context, task T) {
|
|
manager.Remove(task.GetID())
|
|
common.SuccessResp(c)
|
|
}))
|
|
g.POST("/retry", getTargetedHandler(manager, func(c *gin.Context, task T) {
|
|
manager.Retry(task.GetID())
|
|
common.SuccessResp(c)
|
|
}))
|
|
g.POST("/cancel_some", getBatchHandler(manager, func(task T) {
|
|
manager.Cancel(task.GetID())
|
|
}))
|
|
g.POST("/delete_some", getBatchHandler(manager, func(task T) {
|
|
manager.Remove(task.GetID())
|
|
}))
|
|
g.POST("/retry_some", getBatchHandler(manager, func(task T) {
|
|
manager.Retry(task.GetID())
|
|
}))
|
|
g.POST("/clear_done", func(c *gin.Context) {
|
|
isAdmin, uid, ok := getUserInfo(c)
|
|
if !ok {
|
|
// if there is no bug, here is unreachable
|
|
common.ErrorStrResp(c, "user invalid", 401)
|
|
return
|
|
}
|
|
manager.RemoveByCondition(func(task T) bool {
|
|
return (isAdmin || uid == task.GetCreator().ID) &&
|
|
argsContains(task.GetState(), tache.StateCanceled, tache.StateFailed, tache.StateSucceeded)
|
|
})
|
|
common.SuccessResp(c)
|
|
})
|
|
g.POST("/clear_succeeded", func(c *gin.Context) {
|
|
isAdmin, uid, ok := getUserInfo(c)
|
|
if !ok {
|
|
// if there is no bug, here is unreachable
|
|
common.ErrorStrResp(c, "user invalid", 401)
|
|
return
|
|
}
|
|
manager.RemoveByCondition(func(task T) bool {
|
|
return (isAdmin || uid == task.GetCreator().ID) && task.GetState() == tache.StateSucceeded
|
|
})
|
|
common.SuccessResp(c)
|
|
})
|
|
g.POST("/retry_failed", func(c *gin.Context) {
|
|
isAdmin, uid, ok := getUserInfo(c)
|
|
if !ok {
|
|
// if there is no bug, here is unreachable
|
|
common.ErrorStrResp(c, "user invalid", 401)
|
|
return
|
|
}
|
|
tasks := manager.GetByCondition(func(task T) bool {
|
|
return (isAdmin || uid == task.GetCreator().ID) && task.GetState() == tache.StateFailed
|
|
})
|
|
for _, t := range tasks {
|
|
manager.Retry(t.GetID())
|
|
}
|
|
common.SuccessResp(c)
|
|
})
|
|
}
|
|
|
|
func SetupTaskRoute(g *gin.RouterGroup) {
|
|
taskRoute(g.Group("/upload"), fs.UploadTaskManager)
|
|
taskRoute(g.Group("/copy"), fs.CopyTaskManager)
|
|
taskRoute(g.Group("/offline_download"), tool.DownloadTaskManager)
|
|
taskRoute(g.Group("/offline_download_transfer"), tool.TransferTaskManager)
|
|
taskRoute(g.Group("/decompress"), fs.ArchiveDownloadTaskManager)
|
|
taskRoute(g.Group("/decompress_upload"), fs.ArchiveContentUploadTaskManager)
|
|
}
|